Repository navigation
fix(providers): hide exhausted providers and unavailable models in pickers - #160
Conversation
|
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Independent audit of 2997b49 found no actionable source defect. I traced exhausted versus partially available providers, cooldown recovery, retained thread selections, picker navigation/favorites, continuation restrictions, and mobile defaults plus scheduled-task/group-invite callers. The merge preview against 68193a2 preserves #159 and contains the same ten PR files.
174 tests passed independently: ProviderRegistry 98, mobile modelOptions 37, and four web provider/model/selection/navigation files 39. ProviderModelPicker.browser.test.tsx could not launch its five cases because Chromium headless-shell is absent in this environment. The integrated T3 Browser tools are also unavailable, so the PR author's linked-host browser proof was not independently rerun; no native iOS verification is claimed.
Agent Context Budget is green. Fork CI is still running/queued, including final Fork Check; no failed applicable check was observed. Next action: require those checks to finish successfully on this exact head before merging. No source change or CI configuration change is requested from this review.
Reviewed with GPT-6 Astra Pro / ChatGPT.
Stop delayed remote follow-ups whose local task is rejected after Parent Stop. Include remote-only tasks in the normal thread Stop walk. Scope native-load cache completion to its owning raw runtime. Integrate reviewed main #160. Validated with 309 focused tests, changed-file static gates, and direct server/evals/scripts typechecks.
When the last route for a provider entered cooldown, the server reported a warning and the picker could still show a provider with no usable models. Mobile could also reuse a cooled model as the default for a new task.
This change marks an exhausted routed provider unavailable and filters its model choices on web, desktop and mobile. A provider with a working model stays visible. A thread keeps its saved selection and shows its unavailable status. Model selection recovers when a route becomes healthy again.
The linked-host browser scenario failed on base
7ef0e6d44band passed on head2997b4917c. It verified that Sol remained selectable during Astra’s cooldown and that Astra returned after recovery. The server regression failed on the base for Codex and Claude and passed after the change. All changed-file checks passed, including 145 tests. Mobile picker logic was tested. This test run did not exercise the native iOS screen.Implemented with GPT-6 in Codex.